Skip to content

fix: preserve Windows service mode and refresh Pi session catalogs - #158

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/post-merge-audit-2026-11-18
Nov 18, 2026
Merged

ScriptedAlchemy merged 1 commit into
mainfrom
fix/post-merge-audit-2026-11-18

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Why

The post-merge audit found two session-lifecycle regressions that were still present on main at 1857cd2554f068a0c75ac5f109a07afe9398ba16:

Changes

Read the registered Windows task's supported logon mode before replacing its XML, and preserve it through install, restart, and launcher registration. The scheduler's disabled state is still preserved independently.

Expose Pi's active inference catalog and reopen an idle session when a requested hosted model exists in the current catalog but was unavailable when that session started. Existing sessions remain usable for their original model, pending background work prevents premature replacement, and the replacement session is reused.

Extend the existing regression cases to cover independently edited Task Scheduler XML, both logon directions, disabled tasks, routed Pi catalog updates, and the native-to-hosted Pi transition.

Validation

  • Reproduced the Windows and both Pi paths as failing regressions before their respective fixes.
  • On the combined source tree, 189 server tests passed across bootService, serviceLauncher, ProviderSessionManager, and AgentContextBudget.
  • All 254 Pi package tests passed across nine test files.
  • All nine affected package typechecks passed by invoking each package's configured effect-tsgo tsrs --noEmit directly.
  • vp run check:changed 1857cd2554f068a0c75ac5f109a07afe9398ba16 --concurrency 2 passed the native build, formatting, lint, both Knip passes, and GraphQL generation checks. Its cached typecheck launcher could not initialize seccomp_unotify in this environment; its initial combined test run also failed without a test result. The same underlying checks were completed directly as described above, with the server tests run with one worker. The original gate invocation is not represented as a pass.
  • Independent code review covered both final fixes and their related entry points.
  • Integration with merged fix(inference): replace unhealthy proxies and refresh linked models #157 at 13b54bff8ee2be5611bf82806cc5e7559b80f8b0 is conflict-free. The combined tree 8857e19d981139139e72673966357058901bc6f8 passed all 14 targeted proxy/routing and hosted-catalog session tests, including native-to-hosted Pi and pending-work preservation.

Windows scheduler behavior was reproduced with the existing filesystem/process harness on Linux; native Windows and a live Pi/model session were not available. No CI or budget gates were changed. GitHub CI must pass on the exact PR head before merge.

Implemented and verified with GPT-6 Astra Pro in the ChatGPT coding workspace.

Preserve Task Scheduler logon settings across install, restart, and update.
Refresh idle Pi sessions when newly routed models require a fresh catalog.
Extend existing regressions for scheduler-only edits and native Pi transitions.
@changeset-bot

changeset-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6c84273

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 7ef0e6d into main Nov 18, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant