Repository navigation
fix: preserve Windows service mode and refresh Pi session catalogs - #158
Merged
Merged
Conversation
Preserve Task Scheduler logon settings across install, restart, and update. Refresh idle Pi sessions when newly routed models require a fresh catalog. Extend existing regressions for scheduler-only edits and native Pi transitions.
|
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The post-merge audit found two session-lifecycle regressions that were still present on
mainat1857cd2554f068a0c75ac5f109a07afe9398ba16:Changes
Read the registered Windows task's supported logon mode before replacing its XML, and preserve it through install, restart, and launcher registration. The scheduler's disabled state is still preserved independently.
Expose Pi's active inference catalog and reopen an idle session when a requested hosted model exists in the current catalog but was unavailable when that session started. Existing sessions remain usable for their original model, pending background work prevents premature replacement, and the replacement session is reused.
Extend the existing regression cases to cover independently edited Task Scheduler XML, both logon directions, disabled tasks, routed Pi catalog updates, and the native-to-hosted Pi transition.
Validation
bootService,serviceLauncher,ProviderSessionManager, andAgentContextBudget.effect-tsgo tsrs --noEmitdirectly.vp run check:changed 1857cd2554f068a0c75ac5f109a07afe9398ba16 --concurrency 2passed the native build, formatting, lint, both Knip passes, and GraphQL generation checks. Its cached typecheck launcher could not initializeseccomp_unotifyin this environment; its initial combined test run also failed without a test result. The same underlying checks were completed directly as described above, with the server tests run with one worker. The original gate invocation is not represented as a pass.13b54bff8ee2be5611bf82806cc5e7559b80f8b0is conflict-free. The combined tree8857e19d981139139e72673966357058901bc6f8passed all 14 targeted proxy/routing and hosted-catalog session tests, including native-to-hosted Pi and pending-work preservation.Windows scheduler behavior was reproduced with the existing filesystem/process harness on Linux; native Windows and a live Pi/model session were not available. No CI or budget gates were changed. GitHub CI must pass on the exact PR head before merge.
Implemented and verified with GPT-6 Astra Pro in the ChatGPT coding workspace.